Skip to content

Add missing parser files to Python 3.13 Linux and macOS builds #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ntamas
Copy link
Contributor

@ntamas ntamas commented Dec 29, 2024

This PR fixes the CPython 3.13 distributions on Linux and macOS builds to include the additional object files in subdirectories of the Parser directory. Will fix #378 when merged.

Windows builds are unaffected by the bug because the Windows build script uses a different mechanism to collect the object files.

@charliermarsh charliermarsh requested a review from zanieb December 29, 2024 15:25
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb merged commit 916bb0d into astral-sh:main Dec 30, 2024
308 checks passed
@ntamas ntamas deleted the fix/missing-parser-files-python313-unix branch December 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object files missing?
2 participants