Fix #318 cannot pickle metrics #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pickling certain metrics while specifying input type as generic type parameter would result in a failure in Python 3.6. Previous tests didn't cover this case.
Worked around this limitation by using a dummy `Generic` in Python 3.6 and below.
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=======================================
Coverage 79.91% 79.92%
=======================================
Files 133 133
Lines 11135 11143 +8
=======================================
+ Hits 8899 8906 +7
- Misses 2236 2237 +1
Continue to review full report at Codecov.
|
hunterhector
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #318: cannot pickle metrics in Python 3.6.
In Python 3.6 and below, pickling a
Genericsubclass that is specialized (e.g.,Accuracy[float]) would cause an exception. To prevent troubles withExecutorsave & load, we use a dummy implementation ofGenericthrough our home-brewGenericMeta. Basically, it is modified so that for any classFoothat inherits fromGeneric,Foo[T]just returnsFoo.Additional unit tests are also added to verify pickling behavior.