Skip to content

docs for UdpSocket::send have same example as send_to #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
killercup opened this issue Dec 31, 2019 · 3 comments · Fixed by #671
Closed

docs for UdpSocket::send have same example as send_to #652

killercup opened this issue Dec 31, 2019 · 3 comments · Fixed by #671
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@killercup
Copy link
Contributor

cf. https://docs.rs/async-std/1.4.0/async_std/net/struct.UdpSocket.html#method.send
@yoshuawuyts
Copy link
Contributor

Heh, looks like this is similar to #603 where we missed another PR.

@yoshuawuyts yoshuawuyts added bug Something isn't working documentation Improvements or additions to documentation labels Jan 9, 2020
@ghost ghost added the good first issue Good for newcomers label Jan 13, 2020
@Noah-Kennedy
Copy link
Contributor

If no one else is working on it, I think I might have a go at this one.

Noah-Kennedy added a commit to Noah-Kennedy/async-std that referenced this issue Jan 13, 2020
@Noah-Kennedy
Fixes async-rs#652
a4f6806
@Noah-Kennedy Noah-Kennedy mentioned this issue Jan 13, 2020
Merged
@Noah-Kennedy
Copy link
Contributor

Fix should be ready for review.

Noah-Kennedy added a commit to Noah-Kennedy/async-std that referenced this issue Jan 14, 2020
@Noah-Kennedy
Revert "Fixes async-rs#652"
76993dd 
This reverts commit a4f6806
Noah-Kennedy added a commit to Noah-Kennedy/async-std that referenced this issue Jan 14, 2020
@Noah-Kennedy
Revert "Fixes async-rs#652"
0a52864 
This reverts commit a4f6806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docs for UdpSocket::send Noah-Kennedy/async-std
3 participants
@killercup @yoshuawuyts @Noah-Kennedy