Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.4 (regression) not currently running on the Tokio runtime. crash #881

Closed
sync opened this issue Sep 22, 2020 · 4 comments · Fixed by #882
Closed

v1.6.4 (regression) not currently running on the Tokio runtime. crash #881

sync opened this issue Sep 22, 2020 · 4 comments · Fixed by #882

Comments

@sync
Copy link

sync commented Sep 22, 2020

When using the latest async std version:
async-std = { version = "1.6.4", features = ["attributes", "tokio02"] } and tokio02

I get an error message deep down saying not currently running on the Tokio runtime.

I rely on the tokio02 feature so I can keep using https://crates.io/crates/cloud-pubsub that has a dependency on the Tokio runtime.

If I use 1.6.3 instead, I don't get the error
async-std = { version = "=1.6.3", features = ["attributes", "tokio02"] }

I looked at the latest release note and I see nothing related to a potential tokio02 change that might explain why I now get this crash.

I'll attach a sentry crash report and happy to provide further details if necessary

@sync
Copy link
Author

sync commented Sep 22, 2020

Here is the symbolicated crash report from sentry:

3ddcff0bcff64b8f8769056c7fa684e2-symbolicated.crash.zip

@sync sync changed the title v1.6.4 not currently running on the Tokio runtime. v1.6.4 not currently running on the Tokio runtime. crash Sep 22, 2020
@sync sync changed the title v1.6.4 not currently running on the Tokio runtime. crash v1.6.4 (regression) not currently running on the Tokio runtime. crash Sep 22, 2020
@Keruspe
Copy link
Member

Keruspe commented Sep 22, 2020

I'm working on fixing this

Keruspe added a commit to Keruspe/async-std that referenced this issue Sep 22, 2020
Move it into async-global-executor

Fixes async-rs#881

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@Keruspe
Copy link
Member

Keruspe commented Sep 22, 2020

From my testing, works fine both from within local and global tasks now

Keruspe added a commit to Keruspe/async-std that referenced this issue Sep 22, 2020
Move it into async-global-executor

Fixes async-rs#881

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@Keruspe
Copy link
Member

Keruspe commented Sep 22, 2020

@sync while waiting for a release, if you declare a dependency on async-global-executor 1.2.1 with tokio02 feature enabled (as it's disabled by default), async-std should work properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants