Skip to content

Remove Pin API related unsafe code by using pin-project-lite cra… #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Oct 23, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Oct 22, 2019

pin-project-lite is a lightweight version of pin-project written with declarative macros.

@taiki-e taiki-e requested a review from a user October 22, 2019 16:14
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! ♥

This PR removes tons of unsafe code, manual Unpin implementations, and unnecessary Unpin trait bounds. Writing correct stream combinators will be so much easier now.

@ghost ghost changed the title Remove Pin API related unsafe code by using pin-project-lite crate Remove Pin API related unsafe code by using pin-project-lite cra… Oct 23, 2019
@ghost ghost merged commit 944e43d into async-rs:master Oct 23, 2019
@taiki-e taiki-e deleted the safe-pin branch October 23, 2019 11:00
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 31, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant