Skip to content

Expose extension traits in preludes #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Nov 7, 2019
Merged

Expose extension traits in preludes #459

merged 2 commits into from Nov 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2019 •
edited by ghost
Loading

Closes #455

@ghost ghost requested a review from yoshuawuyts November 6, 2019 23:47
yoshuawuyts
yoshuawuyts approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good; seems to be the way we discussed. Thanks for putting in the patch!

@yoshuawuyts yoshuawuyts merged commit a064a5b into async-rs:master Nov 7, 2019
@ghost ghost deleted the expose-ext-traits branch November 7, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-prelude usage
1 participant
@yoshuawuyts