Skip to content

Stabilize most stream method and remove unnecessary macros #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2020
Merged

Stabilize most stream method and remove unnecessary macros #719

merged 10 commits into from
Mar 6, 2020

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Mar 3, 2020 •
edited
Loading

ref: #711

@k-nasa k-nasa force-pushed the remove_re_export branch from abe2946 to 1e18839 Compare March 3, 2020 23:55
@k-nasa k-nasa marked this pull request as ready for review March 4, 2020 00:15
@k-nasa k-nasa requested a review from yoshuawuyts March 4, 2020 13:37
yoshuawuyts
yoshuawuyts requested changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits: we should probably remove the print macros entirely. Other than that this looks great!

@k-nasa k-nasa force-pushed the remove_re_export branch from c0f5a8e to b95bd6c Compare March 5, 2020 01:34
@k-nasa k-nasa force-pushed the remove_re_export branch from d43f675 to ec4b09e Compare March 5, 2020 09:48
@k-nasa k-nasa requested a review from yoshuawuyts March 5, 2020 10:01
@k-nasa k-nasa force-pushed the remove_re_export branch from 7fa9826 to ec5a0d7 Compare March 6, 2020 00:43
@k-nasa k-nasa force-pushed the remove_re_export branch from ec5a0d7 to f33d7f4 Compare March 6, 2020 00:53
yoshuawuyts
yoshuawuyts approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! Thanks so much!

@yoshuawuyts yoshuawuyts merged commit 61f9483 into async-rs:master Mar 6, 2020
@k-nasa k-nasa deleted the remove_re_export branch March 6, 2020 13:37
@taiki-e taiki-e mentioned this pull request Mar 10, 2020
Open
@k-nasa k-nasa mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-nasa @yoshuawuyts