Update futures-timer to 3.0.2 #739
Merged
+6
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't check before creating a PR. Another PR for this is already open #738 |
k-nasa
reviewed
Mar 31, 2020
Comment on lines
-95
to
-113
| fn next_interval(prev: Instant, now: Instant, interval: Duration) -> Instant { | ||
| let new = prev + interval; | ||
| if new > now { | ||
| return new; | ||
| } | ||
|
|
||
| let spent_ns = duration_to_nanos(now.duration_since(prev)).expect("interval should be expired"); | ||
| let interval_ns = | ||
| duration_to_nanos(interval).expect("interval is less that 427 thousand years"); | ||
| let mult = spent_ns / interval_ns + 1; | ||
| assert!( | ||
| mult < (1 << 32), | ||
| "can't skip more than 4 billion intervals of {:?} \ | ||
| (trying to skip {})", | ||
| interval, | ||
| mult | ||
| ); | ||
| prev + interval * (mult as u32) | ||
| } |
There was a problem hiding this comment.
I don't understand this logic, but is it safe to remove it?
There was a problem hiding this comment.
Yes. The logic is quite complex and there is not much documentation for next_interval function. But, as the name suggests, it is trying to find the next Instant to update the Delay with. As the new version of Delay already takes Duration as argument, we don't have to go through that complex logic to find the next Instant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.