Skip to content

run ci on wasm32-unknown-unknown #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Aug 14, 2020

The test failure on this branch represents an actual build error in 1.6.3 on wasm, breaking any wasm projects that depend on async-std. That build error is filed as #851. This PR tries to avoid this situation in the future by adding wasm to the async-std github CI.

@jbr jbr force-pushed the run-ci-on-wasm-target branch from 6d3a4f0 to 047847f Compare August 14, 2020 04:38
steps:
- uses: actions/checkout@master

- name: Install nightly with wasm32-unknown-unknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should use stable for this, there are some current nightlies without wasm32 target support

Copy link
Contributor Author

@jbr jbr Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 5342950 + 8afc6a7 by adding a toolchain matrix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dignifiedquire
Copy link
Member

thanks, merged manually into #863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants