Fix false positive unexpected connection close #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The connection could be incorrectly detected as unexpectedly closed due to a race condition where the exit message was sent before updating the state to `ST_CLOSING`. Modifications: Ensured state update to `ST_CLOSING` happens before sending the exit message. Result: State update to `ST_CLOSING` happens before sending the exit message, preventing false positive unexpected close detections. resolves #275
|
@JohnNiang |
JohnNiang
approved these changes
Feb 17, 2025
|
Hi @jchrys , could we release a new version against this fix? ❤️ |
|
@JohnNiang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The connection could be incorrectly detected as unexpectedly closed due to a race condition where the exit message was sent before updating the state to
ST_CLOSING.Modifications:
Ensured state update to
ST_CLOSINGhappens before sending the exit message.Result:
State update to
ST_CLOSINGhappens before sending the exit message, preventing false positive unexpected close detections.resolves #275