ARC 2256 - Enable user to see the basic skeleton of new config experience #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krazziekay
requested review from
gxueatlassian
and removed request for
gxueatlassian
package.json
Outdated
| "start:main": "tsnd -r tsconfig-paths/register --watch=.env*,db/config.json --inspect=0.0.0.0:9229 --respawn --transpile-only -- src/main.ts", | ||
| "start:worker": "tsnd -r tsconfig-paths/register --watch=.env*,db/config.json --inspect=0.0.0.0:9230 --respawn --transpile-only -- src/worker.ts", | ||
| "start:production": "run-p start:main:production start:worker:production", | ||
| "start:production": "run-p spa:production start:main:production start:worker:production", |
There was a problem hiding this comment.
spa:production should not be here, as in production, we don't need it it. We should copy the compiled assets during build time not run time.
There was a problem hiding this comment.
spa:production removed and added this step in build
| @@ -0,0 +1,30 @@ | |||
| { | |||
| "name": "spa", | |||
There was a problem hiding this comment.
Maybe not matter, but anyway update the name as well;
There was a problem hiding this comment.
Couldn't think of a better name, so keeping it as it is for now
| @@ -0,0 +1,26 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "ES2020", | |||
There was a problem hiding this comment.
/nit
might need put some comments somewhere to justify this.
| */ | ||
| export default defineConfig({ | ||
| plugins: [react()], | ||
| base: "/spa" |
There was a problem hiding this comment.
Shall we use something like /app instead of /spa, as /spa is quite technical details, and /app is more generic.
- Setup for Prod
- Setup for Prod
gxueatlassian
previously approved these changes
Jul 3, 2023
gxueatlassian
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
atlassian-connect.jsonfor loading React SPA pages.Why
How has this been tested?
yarn start, then the SPA can be viewed at URLhttps://ATLASSIAN-INSTANCE.net/spa-index-pageWhats Next?