-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expose errors from the API endpoint in the UI #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
adaf015
to
5778c17
Compare
apiError | ||
}); | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this isnt a bit too much for anyone using the sample to try and understand how to use our SDK. I know this isnt necessary related to our SDK, but not everyone might understand that.
In what event do we get back non-json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I realise now this is probably too much for the sample, the only case that raw HTML would be returned is when the server errors with something other than a token error. So maybe in that instance we can just ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue we could abstract this in a component? That way it's all at least seperated from basic integration?
…m_and_yarn/Sample-01/angular/language-service-15.1.0 Bump @angular/language-service from 15.0.0 to 15.1.0 in /Sample-01
We could potentially extend this to also include examples of how to fix these issues.
For example:
The

audience
is different between the frontend and backendA developer extends this sample to include

requiredScopes
but does not update the frontend/update their token