Skip to content

readme: Using private key with passpharase #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2017
Merged

readme: Using private key with passpharase #353

merged 1 commit into from
May 23, 2017

Conversation

ziluvatar
Copy link
Contributor

Fixes: #350

fiddur
fiddur approved these changes May 23, 2017
View reviewed changes
Copy link
Contributor

@fiddur fiddur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this so it actually works as expected?

README.md Outdated
@@ -23,8 +23,8 @@ $ npm install jsonwebtoken

`payload` could be an object literal, buffer or string. *Please note that* `exp` is only set if the payload is an object literal.

`secretOrPrivateKey` is a string or buffer containing either the secret for HMAC algorithms, or the PEM
encoded private key for RSA and ECDSA.
`secretOrPrivateKey` is a string, buffer or object containing either the secret for HMAC algorithms or the PEM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No oxford comma? :)

@ziluvatar ziluvatar force-pushed the readme-encrypted-priv-key branch from f50ae52 to 6707a91 Compare May 23, 2017 09:02
@ziluvatar
Copy link
Contributor Author

Yes, I did before answering the issue/question. Although, you are required to indicate the algorithm 🤔 I'll add that too.

@ziluvatar ziluvatar force-pushed the readme-encrypted-priv-key branch from 6707a91 to 4e9d778 Compare May 23, 2017 09:08
@ziluvatar ziluvatar merged commit 27a7f1d into auth0:master May 23, 2017
@ziluvatar ziluvatar deleted the readme-encrypted-priv-key branch May 23, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiddur fiddur fiddur approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziluvatar @fiddur