Skip to content

Bump ms version to add support for negative numbers #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Bump ms version to add support for negative numbers #438

merged 1 commit into from
Jan 19, 2018

Conversation

MitMaro
Copy link
Contributor

@MitMaro MitMaro commented Jan 11, 2018

What

zeit/[email protected] added full support for negative numbers, but the package is set to zeit/[email protected]. This can be useful when defining a nbf value with zeit/ms, ie. nbf = '-30m'.

Due to npm's dependency de-duping this can sometimes result in this library using version zeit/[email protected] instead of zeit/[email protected] resulting in invalid results. In my case visionmedia/debug had their version on zeit/ms pinned to 2.0.0.

This PR bumps the version to zeit/[email protected] to ensure that negative numbers in zeit/ms format work as expected.

Dedupe Example

$ npm show ms version
2.1.1

$ npm list ms
@org/[email protected] /Users/mitmaro/code/org/auth-lib
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
  └── [email protected]  deduped

@ziluvatar ziluvatar merged commit 25e0e62 into auth0:master Jan 19, 2018
@ziluvatar
Copy link
Contributor

Thanks @MitMaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants