-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Port over to AutoML common #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ea234ab
Add submodule
eddiebergman eece33b
Port to abstract_ensemble, backend from automl_common
eddiebergman 51fac24
Updated workflow files
eddiebergman 0cd071b
Update imports
eddiebergman e4fae7b
Trigger actions
eddiebergman cd73bdd
Another import fix
eddiebergman 915644a
update import
eddiebergman 8beb4c0
m
eddiebergman 08e649a
Backend fixes
eddiebergman e7a1cfa
Backend parameter update
eddiebergman 7e09437
fixture fix for backend
eddiebergman 8fc2d47
Fix tests
eddiebergman c9b055a
readd old abstract ensemble for now
eddiebergman 74b926c
flake8'd
eddiebergman eda539e
Added install from source to readme
eddiebergman 543feac
Moved installation w.r.t submodules to the docs
eddiebergman 8f373f0
Temporarily remove submodule
eddiebergman a0140aa
Readded submodule
eddiebergman 151f613
Updated to use automl_common under autosklearn
eddiebergman 7e564d5
Updated MANIFEST
eddiebergman 3528aef
Removed uneeded statements from MANIFEST
eddiebergman 5cbc6e5
Fixed import
eddiebergman 1c5d5d9
Fixed comment line in MANIFEST.in
eddiebergman e66ba80
Added automl_common/setup.py to MANIFEST
eddiebergman d4f0884
Added prefix to script
eddiebergman 5a7d9be
Re-added removed title #
eddiebergman 2054887
Added note for submodule for CONTRIBUTING
eddiebergman 036150c
Made the submodule step a bit more clear for contributing.md
eddiebergman 0a40223
CONTRIBUTING fixes
eddiebergman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "autosklearn/automl_common"] | ||
path = autosklearn/automl_common | ||
url = https://github.com/automl/automl_common |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,17 +30,24 @@ Following that we'll tell you about how you can test your changes locally and th | |
It's important to work off the latest changes on the **development** branch. | ||
```bash | ||
# With https | ||
git clone https://github.com/your-username/auto-sklearn | ||
# Note the --recurse-submodules args, we use a submodule autosklearn/automl_common | ||
# so it needs to be downloaded too | ||
git clone --recurse-submodules https://github.com/your-username/auto-sklearn | ||
|
||
# ... or with ssh | ||
git clone [email protected]:your-username/auto-sklearn.git | ||
git clone --recurse-submodules [email protected]:your-username/auto-sklearn.git | ||
|
||
# Navigate into the cloned repo | ||
cd auto-sklearn | ||
|
||
# Create a new branch based off the development one | ||
git checkout -b my_new_branch development | ||
|
||
# If you missed the --recurse-submodules arg during clone or need to install the | ||
# submodule manually, then execute the following line: | ||
# | ||
# git submodule udate --init --recursive | ||
|
||
# ... Alternatively, if you would prefer a more manual method | ||
# Show all the available branches with a * beside your current one | ||
git branch | ||
|
@@ -50,6 +57,11 @@ Following that we'll tell you about how you can test your changes locally and th | |
|
||
# Create a new branch based on the currently active branch | ||
git checkout -b my_new_branch | ||
|
||
# If you missed the --recurse-submodules arg during clone or need to install the | ||
# submodule manually, then execute the following line: | ||
# | ||
# git submodule udate --init --recursive | ||
``` | ||
|
||
The reason to create a new branch is two fold: | ||
|
@@ -335,6 +347,9 @@ Lastly, if the feature really is a game changer or you're very proud of it, cons | |
cd auto-sklearn | ||
git checkout -b my_new_branch development | ||
|
||
# Initialize autosklearn/automl_common submodule | ||
git submodule update --init --recursive | ||
|
||
# Create a virtual environment and activate it so there are no package | ||
# conflicts | ||
python -m venv my-virtual-env | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,17 @@ | ||
recursive-include autosklearn/metalearning/files *.arff | ||
recursive-include autosklearn/metalearning/files *.csv | ||
recursive-include autosklearn/metalearning/files *.txt | ||
include autosklearn/util/logging.yaml | ||
include LICENSE.txt | ||
include requirements.txt | ||
include autosklearn/util/logging.yaml | ||
include autosklearn/requirements.txt | ||
recursive-include autosklearn/experimental/ *.json | ||
include autosklearn/experimental/askl2_training_data.json | ||
include LICENSE.txt | ||
|
||
# Meta-data | ||
recursive-include autosklearn/metalearning/files *.arff *.csv *.txt | ||
recursive-include autosklearn/experimental *.json | ||
|
||
# Remove tests from automl_common | ||
prune autosklearn/automl_common/test | ||
exclude autosklearn/automl_common/setup.py | ||
|
||
# Include automl_common LICENSE and README | ||
include autosklearn/automl_common/LICENSE | ||
include autosklearn/automl_common/README.md | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule automl_common
added at
4c8ab9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.