refactor: use progress_bar more explicitly as a thread #1622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not like the way the progress bar class started itself as soon as it was instatiated, so I changed the way it works to be more intuitive. Namely, ProgressBar can now be used just like a regular thread, so start() has to be called on it for it to start running. Also, join is used to wait for it to finish, which at the same time terminates the thread by maxing out the bar, so that the thread will never hang.
I also added improved docs.