Skip to content

Make upgradecmd to work #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2025
Merged

Make upgradecmd to work #2764

merged 8 commits into from
May 2, 2025

Conversation

felipemadero
Copy link
Collaborator

Why this should be merged

avalanche blockchain upgrade generate always exit with error trying to connect to local network. Also, a given upgrade is never applied to local clusters or local networks.
this PR fixes issues related to L1 configurations:

  • all blockchain configurations are now applied on deploy (upgrade was missing, global node settings was missing)
  • all blockchain configuration updates are now applied on restart (all was missing)
  • global node settings are applied on local network restart
  • upgrade generate is fixed so it does not try to check for balances on local network

How this works

How this was tested

How is this documented

@sukantoraymond
Copy link
Collaborator

Since I don't have a lot of context in this, I think having an E2E for upgrade that includes this change (we already have testcases/upgrade/non-sov/, but im pretty sure those e2e don't cover this change) will go a long way towards understanding how upgrade is meant to be used.

@felipemadero felipemadero merged commit ff59daa into main May 2, 2025
37 checks passed
@felipemadero felipemadero deleted the make-upgrade-to-work branch May 2, 2025 16:03
@github-project-automation github-project-automation bot moved this from Backlog 🧊 to Done 🎉 in avalanchego May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants