Move database creation to database factory package #3899
Merged
+110
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Apr 18, 2025
Signed-off-by: Stephen Buttolph <[email protected]>
StephenButtolph
approved these changes
Apr 28, 2025
| metricsPrefix, | ||
| ) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
nit: could you create more specific formatted errors to the ones here ?
i.e. fmt.Errorf("failed to MakeAndRegister the metricPrefix %s : %w". metricsPrefix, err)
same for the others error in this function.
There was a problem hiding this comment.
I agree with this comment but I don't think it makes sense to block this PR on it because this is a strict refactor.
joshua-kim
approved these changes
Apr 28, 2025
joshua-kim
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It moves database creation function to
database/factorypkg to be used from external pkgs/modules (like subnet-evm)How this works
Database Configuration Refactor:
database/factorypackage: Introduced a newDatabaseConfigstruct and aNewDatabasefunction indatabase/factory/factory.go. This function centralizes the creation of LevelDB, MemDB, and PebbleDB instances, as well as their associated wrappers (e.g., corruptable and meter DBs).Code Simplification in
nodePackage:initDatabasemethod innode/node.gonow uses theNewDatabasefunction from thedatabase/factorypackage, reducing duplicated logic and improving maintainability.How this was tested
e2e tests should cover this + locally
Need to be documented in RELEASES.md?
No