Skip to content

[tmpnet] Separate start of prometheus and promtail collectors #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented May 8, 2025

Why this should be merged

Previously local collectors were always started together. For kube, though, it makes sense to support only starting prometheus (e.g. to collect metrics from the load generation framework) since logs and metrics for nodes will be collected by agents within the kube cluster.

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

Copy link
Contributor

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍
Except for retro-compatibility, do we want to continue supporting TMPNET_START_COLLECTORS? Should we just support log+metrics collection flags to have code a bit simpler? But it's also fine as is, so feel free to ignore.

@maru-ava maru-ava force-pushed the tmpnet-kubeconfig-flags branch from 98c745c to 55a18b1 Compare May 9, 2025 18:51
@maru-ava maru-ava force-pushed the tmpnet-separate-collector-start branch 5 times, most recently from f577044 to ca1a9af Compare May 9, 2025 18:56
@maru-ava
Copy link
Contributor Author

maru-ava commented May 9, 2025

Nice catch 👍 Except for retro-compatibility, do we want to continue supporting TMPNET_START_COLLECTORS? Should we just support log+metrics collection flags to have code a bit simpler? But it's also fine as is, so feel free to ignore.

From the department of 'be careful what you wish for'... The latest commit removes start/stop collectors in favor of starting/stopping them individually.

@maru-ava maru-ava force-pushed the tmpnet-kubeconfig-flags branch from 55a18b1 to 2977b0e Compare May 12, 2025 19:08
Base automatically changed from tmpnet-kubeconfig-flags to master May 12, 2025 20:11
maru-ava added 4 commits May 12, 2025 21:15
Previously local collectors were always started together. For kube,
though, it makes sense to support only starting prometheus (e.g. to
collect metrics from a the load generation framework) since logs and
metrics for nodes will be collected by agents within the kube cluster.
@maru-ava maru-ava force-pushed the tmpnet-separate-collector-start branch from ca1a9af to 2cc6e08 Compare May 12, 2025 20:16
@maru-ava
Copy link
Contributor Author

Rebased

@maru-ava maru-ava enabled auto-merge May 12, 2025 20:16
@maru-ava maru-ava added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 6e04bc0 May 12, 2025
25 checks passed
@maru-ava maru-ava deleted the tmpnet-separate-collector-start branch May 12, 2025 20:47
@github-project-automation github-project-automation bot moved this from Ready 🚦 to Done 🎉 in avalanchego May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Build, test and development tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants