-
Notifications
You must be signed in to change notification settings - Fork 757
[tmpnet] Separate start of prometheus and promtail collectors #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
Except for retro-compatibility, do we want to continue supporting TMPNET_START_COLLECTORS
? Should we just support log+metrics collection flags to have code a bit simpler? But it's also fine as is, so feel free to ignore.
98c745c
to
55a18b1
Compare
f577044
to
ca1a9af
Compare
From the department of 'be careful what you wish for'... The latest commit removes start/stop collectors in favor of starting/stopping them individually. |
55a18b1
to
2977b0e
Compare
Previously local collectors were always started together. For kube, though, it makes sense to support only starting prometheus (e.g. to collect metrics from a the load generation framework) since logs and metrics for nodes will be collected by agents within the kube cluster.
ca1a9af
to
2cc6e08
Compare
Rebased |
Why this should be merged
Previously local collectors were always started together. For kube, though, it makes sense to support only starting prometheus (e.g. to collect metrics from the load generation framework) since logs and metrics for nodes will be collected by agents within the kube cluster.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A