-
Notifications
You must be signed in to change notification settings - Fork 268
[ci] Simplify monitoring configuration #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a36ad9
to
311e118
Compare
311e118
to
a86ebfa
Compare
5418bea
to
bc72b5f
Compare
c8011b6
to
a2605de
Compare
a2605de
to
a621c2a
Compare
371a4c7
to
c405f18
Compare
e142204
to
160ae92
Compare
1 task
29409d4
to
cb402b6
Compare
cb402b6
to
fc7cc1c
Compare
ceyonur
approved these changes
Mar 24, 2025
ceyonur
reviewed
Mar 24, 2025
darioush
approved these changes
Mar 26, 2025
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: maru <[email protected]>
This was referenced Mar 31, 2025
qdm12
pushed a commit
that referenced
this pull request
Mar 31, 2025
Reverts #1440 to be compatible with AvalancheGo v1.13.0 (need to downgrade)
qdm12
pushed a commit
that referenced
this pull request
Apr 1, 2025
Signed-off-by: maru <[email protected]> Co-authored-by: Darioush Jalali <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
Signed-off-by: maru <[email protected]> Co-authored-by: maru <[email protected]> Co-authored-by: Darioush Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously deployment of prometheus and promtail in CI required bash scripts in the repo. The latest version of the run-monitored-tmpnet-cmd custom github action internalizes that capability.
How this works
updates to latest version of run-monitored-tmpnet-cmd
adds a new script -
update_avalanche_version.sh
- to ensure the version of the custom action matches the vendored version of avalanchego. The script is executed in the lint job to enforce this requirement.adds a new script - dev_shell.sh - that starts an avalanchego dev shell that has access to dependencies required by tmpnet for thing like starting collectors of logs and metrics
How this was tested
CI
Need to be documented?
Added a new section in tests/README.md
Need to update RELEASES.md?
N/A
TODO