Skip to content

[ci] Simplify monitoring configuration #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 26, 2025
Merged

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Feb 2, 2025

Why this should be merged

Previously deployment of prometheus and promtail in CI required bash scripts in the repo. The latest version of the run-monitored-tmpnet-cmd custom github action internalizes that capability.

How this works

  • updates to latest version of run-monitored-tmpnet-cmd

  • adds a new script - update_avalanche_version.sh - to ensure the version of the custom action matches the vendored version of avalanchego. The script is executed in the lint job to enforce this requirement.

  • adds a new script - dev_shell.sh - that starts an avalanchego dev shell that has access to dependencies required by tmpnet for thing like starting collectors of logs and metrics

How this was tested

CI

Need to be documented?

Added a new section in tests/README.md

Need to update RELEASES.md?

N/A

TODO

@maru-ava maru-ava added ci testing This primarly focuses on testing labels Feb 2, 2025
@maru-ava maru-ava self-assigned this Feb 2, 2025
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 3 times, most recently from 1a36ad9 to 311e118 Compare February 4, 2025 18:30
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from 311e118 to a86ebfa Compare February 22, 2025 19:56
@maru-ava maru-ava changed the base branch from master to bump-golang-1.23.6 February 22, 2025 19:58
Base automatically changed from bump-golang-1.23.6 to master February 24, 2025 14:41
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 5 times, most recently from 5418bea to bc72b5f Compare February 24, 2025 22:58
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 2 times, most recently from c8011b6 to a2605de Compare March 4, 2025 22:02
@maru-ava maru-ava moved this from In Progress 🏗 to In Review 👀 in avalanchego Mar 4, 2025
@maru-ava maru-ava marked this pull request as ready for review March 4, 2025 22:02
@maru-ava maru-ava requested review from ceyonur, darioush and a team as code owners March 4, 2025 22:02
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from a2605de to a621c2a Compare March 4, 2025 22:03
@maru-ava maru-ava marked this pull request as draft March 4, 2025 22:06
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 6 times, most recently from 371a4c7 to c405f18 Compare March 5, 2025 17:51
@maru-ava maru-ava changed the base branch from master to set-avalanchego-version March 5, 2025 17:52
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from e142204 to 160ae92 Compare March 21, 2025 19:24
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from 29409d4 to cb402b6 Compare March 21, 2025 20:36
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from cb402b6 to fc7cc1c Compare March 21, 2025 20:41
Co-authored-by: Darioush Jalali <[email protected]>
Signed-off-by: maru <[email protected]>
@maru-ava maru-ava enabled auto-merge March 26, 2025 20:29
@maru-ava maru-ava added this pull request to the merge queue Mar 26, 2025
Merged via the queue into master with commit 1a53e9a Mar 26, 2025
13 checks passed
@maru-ava maru-ava deleted the simplify-ci-monitoring branch March 26, 2025 21:12
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in avalanchego Mar 26, 2025
ceyonur added a commit that referenced this pull request Mar 28, 2025
ceyonur added a commit that referenced this pull request Mar 31, 2025
qdm12 pushed a commit that referenced this pull request Mar 31, 2025
Reverts #1440 to be compatible with AvalancheGo v1.13.0 (need to downgrade)
qdm12 pushed a commit that referenced this pull request Apr 1, 2025
Signed-off-by: maru <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
@qdm12 qdm12 restored the simplify-ci-monitoring branch April 2, 2025 08:14
@qdm12 qdm12 deleted the simplify-ci-monitoring branch April 2, 2025 08:59
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
Signed-off-by: maru <[email protected]>
Co-authored-by: maru <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci testing This primarly focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants