Skip to content

[Jex-Generator] Jsonb Type generation #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

SentryMan
Copy link
Collaborator

Adds the explicit Jsonb type generator we have for helidon/javalin to the jex generator

@SentryMan SentryMan added the enhancement New feature or request label Dec 2, 2024
@SentryMan SentryMan added this to the 2.9 milestone Dec 2, 2024
@SentryMan SentryMan self-assigned this Dec 2, 2024
@SentryMan
Copy link
Collaborator Author

@rbygrave it seems the failing test is unrelated to my changes

@rbygrave
Copy link
Contributor

rbygrave commented Dec 2, 2024

So with the test in question we have an interesting overlap for routes:

    routing.get("/common/name/{name}", this::_name);
    routing.get("/common/{id}/{name}", this::_p2);

So perhaps with EA builds the ordering here is changed (compile order of methods is not preserved?) or ... perhaps the routes lose ordering in the internal RoutesBuilder which uses an EnumMap.

I'll change that EnumMap to a LinkedHashMap and see ...

@rbygrave rbygrave merged commit ee26249 into avaje:master Dec 2, 2024
6 checks passed
@SentryMan SentryMan deleted the jsonb branch December 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants