[client] Breaking change - Rename @Client.Import(types=...) to @Client.Import(value=...). That is, rename types -> value #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also shouldn't we be doing |
rbygrave
changed the title
rbygrave
approved these changes
Jan 27, 2025
Yes, these 2.9-RCs are really 3.0-RCs. We started on 2.9.x and I didn't change it ... but maybe we should. |
|
time for 3.0-RC1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now can do
@Client.Import(CustomType.class)This is a breaking change
From:
To:
... and because it is value it can be now written as: