Remove snapshot files when a test file stops using snapshots

[novemberborn]

When --update-snapshots is passed, if AVA executes a test file for which there are snapshots, but no snapshot assertion is run, we should remove the snapshot files.

What's tricky though is if tests are skipped, or if snapshot assertions are skipped, we should not remove the snapshot files.

See https://github.com/avajs/ava/blob/9d3b1bad681e1aad18ad8cd53407a7ccb1fc5782/lib/runner.js#L205:L207.

---

IssueHunt Summary

ninevra has been rewarded.

Backers (Total: $60.00)

• issuehunt ($60.00)

Submitted pull Requests

• #2623 Remove snapshot files when a test file stops using snapshots

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[lo1tuma]

I wonder if Runner is the correct place to implement this. If I remove a test file then the highlighted code in Runner would be never executed, right?

[novemberborn]

Correct, but this issue is for the scenario where the test file still exists.

[IssueHuntBot]

@IssueHunt has funded $60.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[ninevra]

I'd like to work on this, if that's alright?

[novemberborn]

@ninevra yea that'd be great!

[ninevra]

@novemberborn could you award the bounty on this? sorry, i think i submitted the pr on issuehunt too late, which caused the bounty not to be awarded automatically.

[issuehunt-oss]

@novemberborn has rewarded $54.00 to @ninevra. See it on IssueHunt

• 💰 Total deposit: $60.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $6.00