-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Don't set global stack trace limit to be infinite #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Changing the stack trace limit may also impact code-under-test. Instead we should set it to |
We set the limit here: Line 25 in dd9e8b2
Instead we should modify the We need to do the same in the We have some existing code for this already: https://github.com/avajs/ava/blob/dd9e8b2effe541f9f232ee622452343dac5895dd/lib/test.js#L24:L31 |
Infinity depth stack traces hardly seem necessary, but that is what we are currently doing.
#482 fixes that for
t.plan()
, which I think is important, sincet.plan()
generates a stack trace whether there is a test failure or not.My remaining question is whether or not we should shorten them globally. I am not overly concerned about the performance impact of failing assertions, more so other libraries (like bluebird longStackTrace support) that might be creating overly long stacks and slowing things down.
Some investigation is needed here. If an
Infinity
value does not hurt the speed of a passing test suite, then let's leave it there. Otherwise we should bikeshed on how long it should be.The text was updated successfully, but these errors were encountered: