Skip to content

fails running test in node_modules #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mastilver
Copy link

I've got a weird use case where I want to run test files inside node_modules: I want to share test files between several modules

Is it something that you want to handle?

@novemberborn
Copy link
Member

Does specifying a ./node_modules/shared-tests as a test pattern work? (I'm not sure, and I don't have a dev environment on the laptop I'm tying this from.)

Does our macro support help your use case?

What kind of tests are you sharing?

@mastilver
Copy link
Author

mastilver commented Dec 4, 2016

For this package: https://github.com/mastilver/nosqwal/tree/master/packages/nosqwal-memory
inside package.json, I set: ava.files to ["./node_modules/nosqwal-test/test/*.js"]

I believe it's an intended behavior given this test:

ava/test/api.js

Line 595 in 58a2e68

test(prefix + 'test file in node_modules is ignored', function (t) {

I would be happy this #1137 being solved :)
I guess you can close this one

@novemberborn
Copy link
Member

@mastilver ah, that traces back to #226. #736 discusses further changes to those patterns. IMO your setup should work, exotic though it is.

Closing in favor of #736.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants