Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so since writing
browser-env
I have come up with a cleaner solution,window
.It's been working well for me so far and resolves some of the issues raised in #1092.However, it requires a small code change and is only viable for smaller modules without lots of dependencies that also require a browser environment. For other modules you'll still need
browser-env
. For that reason I think it would be best to continue to recommendbrowser-env
, but highlight the issues raised in #1092 and offerwindow
as a possible alternative.Happy to change the wording, just pretty much copied it over from what I've got in the
browser-env
readme.