Skip to content

Docs : Update common-pitfalls.md with issue 1319 #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Docs : Update common-pitfalls.md with issue 1319 #1652

merged 2 commits into from
Jan 24, 2018

Conversation

jy95
Copy link
Contributor

@jy95 jy95 commented Jan 23, 2018

It adds the bug from issue #1319 into the common-pitfalls.md.

jy95 and others added 2 commits January 23, 2018 18:45
@novemberborn
Copy link
Member

@jy95 I've pushed some updates. What do you think?

@jy95
Copy link
Contributor Author

jy95 commented Jan 24, 2018

Less text is more simple :)
For the FR translation it should be :

C'est un problème connu. Vous devez mettre vos tests dans un dossier nommé test ou __tests__

@forresst
Copy link
Contributor

@jy95 I note it. I will do the necessary on the French translation when the necessary will have been done on the AVA repository

@novemberborn novemberborn merged commit c2b42ec into avajs:master Jan 24, 2018
@novemberborn
Copy link
Member

Thanks @jy95!

@forresst I think @jy95 was interested in doing a PR to https://github.com/avajs/ava-docs/blob/master/fr_FR/docs/common-pitfalls.md to reflect the changes here.

@jy95
Copy link
Contributor Author

jy95 commented Jan 24, 2018

@novemberborn I push the PR right now : avajs/ava-docs#45 . No problem for any change, you are free to change whatever you want ^^

forresst pushed a commit to avajs/ava-docs that referenced this pull request Jan 25, 2018
Docs FR: Update common-pitfalls.md with issue 1319
Translation of original docs : avajs/ava#1652
@forresst
Copy link
Contributor

Thanks @jy95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants