Add t.timeout()
#2015
Merged
Add t.timeout()
#2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novemberborn
requested changes
Jan 13, 2019
|
Hi @novemberborn, thanks a lot for the quick feedback! I've tried to address everything you've mentioned. Please look over the updated changes when you find the time. |
novemberborn
approved these changes
Jan 20, 2019
|
This is great, thanks @dflupu. I've pushed two more tweaks, let me know what you think. |
|
I'm rather curious why you'd go through the trouble of checking for Timer#refresh. Not that I have anything against it. |
It's the modern API and should be more efficient than recreating the timer, closure, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565
As suggested in the issue, the timeout is refreshed whenever an assertion is made.
I'm not sure if the typescript or flow definitions need to be updated.