Fix watch mode with mini reporter #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcdevil good find! I've pushed one tweak, since we should still discard stdin if you're not using watch mode. |
novemberborn
approved these changes
Apr 25, 2020
|
You are right, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, I solved the issue with the mini reporter + watch mode:
It turned out, the terminal spinner package, ora doesn't pipes through the stdin by default, which was a breaking change in its 4.0.0 relase. I suppose during one of the dependency update the effect of this change was overlooked and caused the issue.
I ran the test locally on Linux, everything was green.
Please review and merge it accordingly!
Fixes #2458.