Standardize colors across reporters. #412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR avajs#410 missed a color change on a single log line, See: avajs#410 (comment) Using this convention will make it much easier to review PR's. No need to remember what color is used where, just ensure they don't use chalk directly, and alias the color with it's intended purpose in the colors module.
| var Promise = require('bluebird'); | ||
| var pkgConf = require('pkg-conf'); | ||
| var colors = require('./lib/reporters/colors'); |
There was a problem hiding this comment.
lib/reporters was intended to contain files of reporters only. lib/colors.js would be just fine as well
|
LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #410 missed a color change on a single log line,
See: #410 (comment)
Using this convention will make it much easier to review PR's. No need to remember what color is used where, just ensure they don't use chalk directly, and alias the color with it's intended purpose in the colors module.