no-import-test-files incorrectly flags modules that end in .js

[mearns]

Using all the default options, the following line in a test file is incorrectly flagged as violating the no-import-test-files rule:

var highlight = require('highlight.js')

It appears that any module name ending in .js will similarly be flagged as a violation. However, the semantics for node's require function will only look for local files if they start with a dot, so this will always be importing a module, not a test file.

gmartigny earned $30.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[IssueHuntBot]

@IssueHunt has funded $30.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[GMartigny]

Hi @mearns,

I cannot reproduce your issue. Could you tell which version of eslint and eslint-plugin-ava you're using ? Could you maybe provide a simple repo showing the configuration you are using ?

Thanks

[mearns]

Sure, you can clone this repo and checkout the "eslint-plugin-ava-215" branch: https://github.com/mearns/lowlight/tree/eslint-plugin-ava-215, then run "npm run format". It runs xo which runs eslint with the ava/no-import-test-files rule, and gives the following violation:

  test/index.js:3:17
  ✖  3:17  Test files should not be imported  ava/no-import-test-files

  1 error

Note that this is with eslint-plugin-ava version 5.1.1

[IssueHuntBot]

@sindresorhus has rewarded $27.00 to @GMartigny. See it on IssueHunt

• 💰 Total deposit: $30.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $3.00