-
Notifications
You must be signed in to change notification settings - Fork 49
no-ignored-test-files
does not work when test files are manually transpiled
#252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ava/no-ignored-test-files
does not work when test files are manually transpiledno-ignored-test-files
does not work when test files are manually transpiled
Yea you're right. I'm not sure what the best solution is. I guess we should add back a configuration option, allowing you to override the glob patterns. We'd have to change the caching here to include a cache key that can be provided from the ESLint rule. That way we can derive a different helper for each use case. How would you prefer to override the patterns? Override |
I'm not sure I understand the two approaches you mention, could you please rephrase them? An array of globbing strings would work for my case, and probably other users with similar setups. |
…-import-test-files rules Fixes #252.
…-import-test-files rules Fixes #252.
Uh oh!
There was an error while loading. Please reload this page.
If I understood correctly, the new
no-ignored-test-files
uses the Ava configuration to figure out where test files are.However I transpile my tests with Babel from
test/**
tobuild/test/**
. I explicitly use{ babel: false, compileEnhancements: false }
.Which means
test/**
are linted, butbuild/test/**
are run by Ava. Under those circumstances,no-ignored-test-files
assumption is wrong and reports all my test files witherror AVA ignores this file
.The text was updated successfully, but these errors were encountered: