Skip to content

Regular expression in t.deepEqual() shouldn't trigger warning #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Airkro opened this issue Aug 24, 2019 · 3 comments · Fixed by #276
Closed

Regular expression in t.deepEqual() shouldn't trigger warning #270

Airkro opened this issue Aug 24, 2019 · 3 comments · Fixed by #276
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@Airkro
Copy link

Airkro commented Aug 24, 2019

Issuehunt badges

Rule: no-incorrect-deep-equal

Example:

const ext2regexp = require('ext-to-regexp');

const jsx = ext2regexp('js', 'jsx');

t.deepEqual(jsx, /\.(js|jsx)$/); //  shouldn't trigger warning

Note: This issue has a bounty, so it's expected that you are an experienced programmer and that you give it your best effort if you intend to tackle this. Don't forget, if applicable, to add tests, docs (double-check for typos). And don't be sloppy. Review your own diff multiple times and try to find ways to improve and simplify your code. Instead of asking too many questions, present solutions. The point of an issue bounty is to reduce my workload, not give me more. Include a 🦄 in your PR description to indicate that you've read this. Thanks for helping out 🙌 - @sindresorhus


IssueHunt Summary

mikaoelitiana mikaoelitiana has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@Airkro
Copy link
Author

Airkro commented Aug 24, 2019

#158

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 17, 2019

@issuehunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Sep 17, 2019
mikaoelitiana pushed a commit to mikaoelitiana/eslint-plugin-ava that referenced this issue Sep 20, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Feb 20, 2020

@sindresorhus has rewarded $36.00 to @mikaoelitiana. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants