Skip to content

Declare a JSON schema in 'default' for each rule #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Declare a JSON schema in 'default' for each rule #222

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2958c0a
Declare a JSON schema in 'default' for each rule
Manu1400 Mar 25, 2019
d812210
Fix #211: add the new rule 'meta.type' property
Manu1400 Mar 26, 2019
198a21c
adopt the review requesting changes
Manu1400 May 10, 2019
6d47c3e
remove schema with empty array
Manu1400 May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rules/assertion-arguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,16 @@ const schema = [{
enum: [
'always',
'never'
]
],
default: null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined would be better

}
}
}];

module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
},
Expand Down
4 changes: 3 additions & 1 deletion rules/assertion-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,14 @@ const schema = [{
enum: [
'always',
'never'
]
],
default: 'always'
}];

module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename, '4211212daf1bfcfff3ebc5d4efdc4ba1a87acbf1')
},
Expand Down
6 changes: 5 additions & 1 deletion rules/max-asserts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,16 @@ const create = context => {
};

const schema = [{
type: 'integer'
title: 'maximum number of assertions for each test',
type: 'integer',
minimum: 0,
default: 5
}];

module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
},
Expand Down
4 changes: 3 additions & 1 deletion rules/no-async-fn-without-await.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-cb-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-duplicate-modifiers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-identical-title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
14 changes: 13 additions & 1 deletion rules/no-ignored-test-files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,29 @@ const create = context => {
};

const schema = [{
title: 'one option: files',
$comment: 'the default value of option `files` is from package.json or ava.config.js',
type: 'object',
properties: {
files: {
type: 'array'
type: 'array',
minItems: 0,
uniqueItems: true,
items: {
type: 'string'
},
examples: [
['lib/**/*.test.js', 'utils/**/*.test.js']
],
default: null
}
}
}];

module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
},
Expand Down
14 changes: 13 additions & 1 deletion rules/no-import-test-files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,28 @@ const create = context => {
};

const schema = [{
title: 'one option: files',
$comment: 'the default value of option `files` is from package.json or ava.config.js',
type: 'object',
properties: {
files: {
type: 'array'
type: 'array',
minItems: 0,
uniqueItems: true,
items: {
type: 'string'
},
examples: [
['lib/**/*.test.js', 'utils/**/*.test.js']
],
default: null
}
}
}];

module.exports = {
create,
type: 'problem',
meta: {
docs: {
url: util.getDocsUrl(__filename)
Expand Down
4 changes: 3 additions & 1 deletion rules/no-invalid-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-nested-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-only-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
},
fixable: 'code'
fixable: 'code',
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-skip-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ const create = context => {

module.exports = {
create,
type: 'problem',
meta: {
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-skip-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
},
fixable: 'code'
fixable: 'code',
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-statement-after-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-todo-implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-todo-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/no-unknown-modifiers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/prefer-async-await.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/prefer-power-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/test-ended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
3 changes: 3 additions & 0 deletions rules/test-title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ const create = context => {
};

const schema = [{
type: 'string',
default: 'if-multiple',
enum: [
'always',
'if-multiple'
Expand All @@ -43,6 +45,7 @@ const schema = [{
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
},
Expand Down
4 changes: 3 additions & 1 deletion rules/use-t-well.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'problem',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/use-t.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/use-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ const create = context => ({
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};
4 changes: 3 additions & 1 deletion rules/use-true-false.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ const create = context => {
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
url: util.getDocsUrl(__filename)
}
},
schema: []
}
};