Skip to content

Add test-title-format rule #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 27, 2019
Merged

Add test-title-format rule #235

merged 23 commits into from
May 27, 2019

Conversation

GMartigny
Copy link
Contributor

Fix #157

sindresorhus
sindresorhus requested changes Apr 30, 2019
View reviewed changes
@sindresorhus
Copy link
Member

You also need to add it to the readme.

@sindresorhus
Copy link
Member

Can you help review the other PRs? 🙏

@GMartigny
Copy link
Contributor Author

Can you help review the other PRs?

Yes, I don't know up to what point I'm relevant, but I'll try to help.

@GMartigny
Copy link
Contributor Author

Also, I have no idea how to (or even if I should) test crashing test-case. Maybe by supercharging @jfmengels's eslint-ava-rule-tester ?

@sindresorhus
Copy link
Member

sindresorhus commented May 14, 2019 •
edited
Loading

Also, I have no idea how to (or even if I should) test crashing test-case.

No rule should be crashing, so if it is, it should be fixed and then adding a normal (regression) test.

@sindresorhus sindresorhus changed the title Add the test-title-format rule Add test-title-format rule May 14, 2019
sindresorhus
sindresorhus requested changes May 14, 2019
View reviewed changes
@GMartigny
Copy link
Contributor Author

No rule should be crashing

I was talking about the case of an invalid regexp (#235 (comment))

@sindresorhus
Copy link
Member

I don't think we need to test that.

sindresorhus
sindresorhus reviewed May 18, 2019
View reviewed changes
@sindresorhus
Copy link
Member

Can you fix the merge conflict?

@sindresorhus
Copy link
Member

This was not done properly: #235 (comment)

sindresorhus
sindresorhus reviewed May 23, 2019
View reviewed changes
@sindresorhus
Copy link
Member

#235 (comment)

⬆️

@GMartigny
Copy link
Contributor Author

This was not done properly: #235 (comment)

Sorry, I thought you were talking about the Enforce -> Ensure bit. All good now.

@sindresorhus sindresorhus merged commit a184661 into avajs:master May 27, 2019
@GMartigny GMartigny deleted the addTestTitleFormat branch July 30, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: test-title-format
2 participants
@GMartigny @sindresorhus