Skip to content

Add support for the new eslint meta.type property #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2019

Conversation

GMartigny
Copy link
Contributor

@GMartigny GMartigny commented May 15, 2019

Fix #211

Since #222 looks stale (Closes #222)

Few interrogations:

  • no-import-test-file: this is not a problem per se, but I don't know to which point it mess with AVA
  • no-statement-after-end: it seems to works with statement after t.end, but I might be missing something as I don't know what AVA does.
  • assertion-arguments: too few arguments won't prevent AVA from working (no crash), but it will always fail. Is this more problem or suggestion then ?

@sindresorhus
Copy link
Member

no-import-test-file: this is not a problem per se, but I don't know to which point it mess with AVA

suggestion

no-statement-after-end: it seems to works with statement after t.end, but I might be missing something as I don't know what AVA does.

problem (it could cause weird issues)

assertion-arguments: too few arguments won't prevent AVA from working (no crash), but it will always fail. Is this more problem or suggestion then ?

problem

@sindresorhus
Copy link
Member

Can you fix the merge conflict?

@sindresorhus sindresorhus merged commit 60640f0 into avajs:master May 20, 2019
@GMartigny GMartigny deleted the addMetaType branch May 21, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new rule meta.type property
2 participants