-
Notifications
You must be signed in to change notification settings - Fork 49
Add defaults to schema #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I opened an issue to |
👍 With a TODO comment about removing the fallback in the next major version. |
@sindresorhus I think I got it right this time? Although now I'm thinking I should just file an Issue for it and include a link in the TODO comment. 😛 |
👍 |
@MrHen Can you submit the PR URL here: https://issuehunt.io/r/avajs/eslint-plugin-ava/issues/214 ? |
@sindresorhus Done. Sorry, I keep forgetting it isn't automatic. |
Fixes #214.
Honestly, I'm not sure this issue makes a lot of sense. There were only three rules I saw that had options at all:
assertion-arguments
: Default isundefined
. I added it explicitly but it seems kind of redundant.max-asserts
: Cannot use a default as per Use JSON schemadefault
in rules #214 (comment). I'm not a big fan of non-object options anyway. I recommend converting from the numeric option to an object which would then pick up the default. This would be a breaking change, though. Alternatively, set the default inschema
but also use the fallback increate
.test-title-format
: Default is alsoundefined
.Am I missing something about this request? There was no
Object.assign
usage to replace.