Add use-t-throws-async-well rule
#278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Feb 19, 2020
|
Can you add an auto-fixer? It would just add |
|
@sindresorhus done |
|
Looks good. IssueHunt is down, so remind me another day and I'll reward it. |
|
@sindresorhus ping =D |
|
@sindresorhus BTW, any info on how issuehunt is doing? Seems dying out to me. |
|
No updates unfortunately: https://spectrum.chat/issuehunt/general/error-when-accessing-an-issue-page~edd3be59-9228-472f-ae32-ce888e56bc1c You could try emailing them at [email protected] |
|
Wait, I can access everything including issue pages. What I meant is dying out as a project. It was the most promising one to put opensource on commercial rails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274
Ensure that
t.throwsAsync()andt.notThrowsAsync()aren't called without await(or some other action using returned promise).🦄
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
t.throwsAsync()andt.notThrowsAsync()should be awaited onIssueHunt has been backed by the following sponsors. Become a sponsor