Add equality checks to prefer-t-regex rule
#297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaniM
force-pushed
the
better-prefer-t-regex
branch
from
1808898 to
f4c109e
Compare
JaniM
force-pushed
the
better-prefer-t-regex
branch
from
f4c109e to
c18bc37
Compare
sindresorhus
requested changes
Mar 9, 2020
| @@ -62,6 +62,26 @@ ruleTester.run('prefer-t-regex', rule, { | |||
| code: header + 'const reg = /\\d+/;\ntest(t => t.true(reg.test(foo.bar())));', | |||
| output: header + 'const reg = /\\d+/;\ntest(t => t.regex(foo.bar(), reg));', | |||
| errors: errors('regex') | |||
| }, | |||
| { | |||
| code: header + 'test(t => t.is(foo(), /\\d+/));', | |||
There was a problem hiding this comment.
Can you also add version of these tests using new RegExp()?
There was a problem hiding this comment.
Do we want to expand the functionality for this? The original regex detection logic only matches regex literals, not expressions resolving to a regex. Resolving whether or not any given expression resolves to a regex pretty much requires eval, so we'd have to special-case new RegExp().
There was a problem hiding this comment.
We don't need to resolve expression, but we should support an inline new RegExp() call.
|
Due to the current situation, I don't have time to finish this. Anyone can pick this up. |
|
Thanks for the update @JaniM. Good luck ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275.
These are the maximal reasonable rules I could think of.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
t-prefer-regexruleIssueHunt has been backed by the following sponsors. Become a sponsor