feat: int mapped to enum #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing check looks like be related to a broken version of I would prefer to leave it as is in order not to drift far away from the original repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by danielgtaylor#273
As you can see, the original PR was closed because it didn't handle nicely values that are not defined in the enum.
I believe it is still valuable to have this behavior because it at least reduces the risk of a runtime error (but it doesn't eliminate it completely - for the values without mapping).
Also, if you look at the newly proposed PR in betterproto, the usage will be the same, so we will be prepared for future releases.