Skip to content

define LIBMEMCACHED_AWESOME #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Jul 13, 2021

I think nobody should need this for code, as everything should be compatible.

But it may be useful to report which project is used

Example

$ php --ri memcached

memcached

memcached support => enabled
Version => 3.1.5
libmemcached version => 1.1.0
...

This may allow to adapt output and avoid user confusion, such as
libmemcached-awesome version => 1.1.0

Alternative way may be to change LIBMEMCACHED_VERSION_STRING = "1.1.1 (awesome)", but this may raise issues in some project.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #115 (6e732f4) into v1.x (e5c1347) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            v1.x    #115   +/-   ##
=====================================
  Coverage     68%     68%           
=====================================
  Files        191     191           
  Lines      17445   17445           
=====================================
  Hits       11888   11888           
  Misses      5557    5557           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c1347...6e732f4. Read the comment docs.

@sodabrew
Copy link

New maintenance of libmemcached makes me irrationally happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants