Skip to content

./scripts/build.js/tsc() function will always fail due to undefined symbol allDiagnostics #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justingrant opened this issue Oct 19, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@justingrant
Copy link
Contributor

Describe the bug
#4007 added a new ./scripts/build.js file with a tsc() function. This function will always throw because allDiagnostics is always undefined. In fact there's no other place in the amplify-js codebase where this symbol is used.

allDiagnostics.forEach(diagnostic => {

To Reproduce
I was able to repro this last night by just running yarn run build. But before filing this issue I wanted to verify on a clean dev environment so I ran yarn run clean and tried a build again and got no errors. So clearly something was corrupted somewhere in my original dev environment. I'm not sure why my previous environment ended up calling tsc() but a clean one didn't.

That said, this tsc() function will always throw if it's run, so either this is unused code that should be removed, or this code will need to be fixed.

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants