Skip to content

feat: PR #369 with reverting back to AmplifyModelRegistration #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 21, 2020

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Apr 21, 2020

This PR is based on this PR #369, but reverts changes back to AmplifyModelRegistration until we can:

  1. Get alignment on the name we will use
  2. Make appropriate changes in the codegen package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2 wooj2 changed the title PR #369 with reverting back to AmplifyModelRegistration feat: PR #369 with reverting back to AmplifyModelRegistration Apr 21, 2020
Copy link
Contributor

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this forward

@wooj2 wooj2 merged commit a787029 into master Apr 21, 2020
@wooj2 wooj2 deleted the feature/datastore-config-revertAM branch April 22, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants