Skip to content

fix(log): filenotfound exception when cfn submit cluttering logs #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix(log): filenotfound exception when cfn submit cluttering logs #213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b774e92
switch try/except to if path exists before build path removal
Nov 4, 2022
9b78315
set rmtree to ignore errors
Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions python/rpdk/python/codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,8 @@ def package(self, project, zip_file):

@staticmethod
def _remove_build_artifacts(deps_path):
try:
shutil.rmtree(deps_path)
except FileNotFoundError:
LOG.debug("'%s' not found, skipping removal", deps_path, exc_info=True)
LOG.debug("Removing '%s' folder.", deps_path)
shutil.rmtree(deps_path, ignore_errors=True)

def _build(self, base_path):
LOG.debug("Dependencies build started from '%s'", base_path)
Expand Down