update code formatting and buildspec #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobywf
suggested changes
Jun 25, 2019
There was a problem hiding this comment.
nice! except for the Handlers.yaml / template.yml (which tbh, we broke), this looks great.
you've also used type hints, something we don't use in the rpdk. it might be good to validate them during CI, but i don't really have experience with that. i think mypy does this?
|
still missing ci for type hints, let me get that in before review |
rjlohan
reviewed
Jun 25, 2019
tobywf
approved these changes
Jun 25, 2019
brianlaoaws
added a commit
to brianlaoaws/cloudformation-cli-python-plugin
that referenced
this pull request
Nov 25, 2024
…master-2 Add new operation status translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4
Description of changes:
No functional changes in this pr. ran code through same tools as rpdk core (
isort,black,flake8, etc), updated buildspec to usepre-commitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.