Add release job to staging repo with Github Actions #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshikg
reviewed
Jan 11, 2021
| @@ -0,0 +1,27 @@ | |||
| # This workflow will put the project in our staging repo | |||
| name: Releasing Project to maven | |||
There was a problem hiding this comment.
Looks good to me. Is there some way to test this?
There was a problem hiding this comment.
https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/runs/1683532098?check_suite_focus=true <- here's a test run. it successfully stages a release in our staging repository. I cut a release to trigger this and it successfully uploaded the maven package to our staging repo.
anshikg
approved these changes
Jan 11, 2021
PatMyron
approved these changes
Jan 11, 2021
PatMyron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This PR automates releases to our maven staging repo. Similar to aws-cloudformation/cloudformation-cli-java-plugin#339
This release workflow uses the official java github action to set up the necessary credentials, and the deploy stage executes the command.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.