Prevent generated types from colliding with Resources

[AaronME]

Signed-off-by: Aaron Eaton [email protected]

Issue #, if available: crossplane-contrib/provider-aws#876

Description of changes:

It is possible to have a name collision between a Crossplane Managed Resource and a generated type based on a resource's fields. A good example of this is the SecurityGroup type, which is both a Managed Resource and a generated type.

Whichever type is declared in the highest apiVersion will become the "storage version" for the given type.

For SecurityGroup, this has no impact, because the Managed Resource is version v1beta1 and the generated type is only in lower versions.

But for the proposed Route resource, the Managed Resources is v1alpha1 and a generated type exists in v1beta1, resulting in v1beta1 becoming the storage version. Because the storage version is generated, it lacks crossplane required fields status and synced.

Marking all generated types with // +kubebuilder:skipversion will prevent them from becoming the storage version for a Managed Resource of the same name.

[ack-bot]

Hi @AaronME. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vijtrip2]

/ok-to-test

[muvaf]

Thanks @AaronME !

[jaypipes]

👍

[jaypipes]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AaronME, jaypipes, muvaf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jaypipes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment