support custom fields of list/scalar/map types #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functionality for the generator.yaml file to contain a
`FieldConfig.Type` attribute that is the Go type override string for a
field. If the Go type of the field cannot be inferred via the Create
Input/Output shape *or* via the `FieldConfig.From` (SourceFieldConfig)
value, we can look at this new `FieldConfig.Type` value and construct a
`aws-sdk-go/private/model/api:ShapeRef` object manually.
Thus, with this patch, we can do something like this (example from the
iam-controller's generator.yaml file, which is what I tested this patch
on):
```yaml
resources:
Role:
fields:
Policies:
type: "[]*string"
```
Signed-off-by: Jay Pipes <[email protected]>
jaypipes
added a commit
to jaypipes/ack-iam-controller
that referenced
this pull request
Jan 18, 2022
Regenerate the IAM controller with ACK runtime and code-generator v0.16.1 and the code-generator functionality in aws-controllers-k8s/code-generator#268. Signed-off-by: Jay Pipes <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality for the generator.yaml file to contain a
FieldConfig.Typeattribute that is the Go type override string for afield. If the Go type of the field cannot be inferred via the Create
Input/Output shape or via the
FieldConfig.From(SourceFieldConfig)value, we can look at this new
FieldConfig.Typevalue and construct aaws-sdk-go/private/model/api:ShapeRefobject manually.Thus, with this patch, we can do something like this (example from the
iam-controller's generator.yaml file, which is what I tested this patch
on):
Signed-off-by: Jay Pipes [email protected]
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.