-
Notifications
You must be signed in to change notification settings - Fork 202
Return OpTypeList
for singular plurals
#269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this would be a single line changed (line 128, changed to OpTypeList instead of OpTypeGet to deal with the DhcpOption misnaming...) but I see a bunch of changes here.
Yeah, did some cleanup while here.. tried to break out by commits; sorry if it's still cluttered. No other functionality was added/updated. |
/approve |
Got it, backed out clarifications |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brycahta, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: N/A, heuristic is returning
ReadOne
operation forDescribeDhcpOptions
when it is aReadMany
callDescription of changes:
OpTypeList
instead ofOpTypeGet
for "singular plural" in"Describe"
processingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.