Skip to content

Return OpTypeList for singular plurals #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Return OpTypeList for singular plurals #269

merged 1 commit into from
Jan 18, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: N/A, heuristic is returning ReadOne operation for DescribeDhcpOptions when it is a ReadMany call

Description of changes:

  • returns OpTypeList instead of OpTypeGet for "singular plural" in "Describe" processing
  • removes duplicate code
  • updates comments on singular-plural description to be clearer and present in all affected areas

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this would be a single line changed (line 128, changed to OpTypeList instead of OpTypeGet to deal with the DhcpOption misnaming...) but I see a bunch of changes here.

@brycahta
Copy link
Contributor Author

I was thinking this would be a single line changed (line 128, changed to OpTypeList instead of OpTypeGet to deal with the DhcpOption misnaming...) but I see a bunch of changes here.

Yeah, did some cleanup while here.. tried to break out by commits; sorry if it's still cluttered. No other functionality was added/updated.

@vijtrip2
Copy link
Contributor

/approve

@brycahta
Copy link
Contributor Author

I was thinking this would be a single line changed (line 128, changed to OpTypeList instead of OpTypeGet to deal with the DhcpOption misnaming...) but I see a bunch of changes here.

Got it, backed out clarifications

@brycahta brycahta requested a review from jaypipes January 18, 2022 21:19
@vijtrip2
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit ff8a108 into aws-controllers-k8s:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants