Use SetConfig in SetResourceForStruct when target shape has no members

[brycahta]

Issue #, if available: aws-controllers-k8s/community#1146

This is a follow-up to #289. A targetShape without members in SetResourceForStruct will not be processed today; however, this is not desired behavior for all APIs such as EC2's DHCPOptions resource.

This patch will look up and consume SetConfig in SetResourceForStruct when targetShape has no members like when DHCPOptions' field, DHCPConfigurations.Values []*string, aligns (by name) with aws-sdk's output shape, DhcpConfigurations.Values []*AttributeValue. Instead of skipping the processing of Values []*string field, it will check if a SetConfig exists and if it's valid (referencing a real shape in sourceShape), then use that updated field to source the target field's value resulting in using DhcpConfigurations.Values.Value *string to populate the resource's DHCPConfigurations.Values []*string.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jaypipes]

Correct that one hard-coded OpTypeList thing and I'm good with this, thank you @brycahta!

[jaypipes]

This is fine for now, but I recommend we clean up the setResourceForScalar() method implementation to be able to properly handle this only using the sourceShapeRef information.

[brycahta]

logs from failing s3-olm-test

==== building s3-controller release artifacts ====
Building release artifacts for s3-v0.0.13
Generating common custom resource definitions
Generating custom resource definitions for s3
Generating RBAC manifests for s3
Generating operator lifecycle manager bundle assets for s3
Error: canot clone repository: context deadline exceeded
make: *** [Makefile:36: build-controller] Error 1

[brycahta]

/test s3-olm-test

[jaypipes]

👍

[jaypipes]

You might consider adding:

      method: CREATE

here in order to exercise the OpType passing down into the recursive SetResourceForXXX functions.

[jaypipes]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brycahta,jaypipes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment